[wp-trac] [WordPress Trac] #47069: The admin bar on the front end has reduced functionality and bugs when jQuery not being used

WordPress Trac noreply at wordpress.org
Wed Dec 11 02:39:09 UTC 2019


#47069: The admin bar on the front end has reduced functionality and bugs when
jQuery not being used
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  5.3.1
Component:  Toolbar                  |     Version:  5.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots early    |     Focuses:  accessibility,
  has-patch 2nd-opinion needs-       |  javascript
  testing                            |
-------------------------------------+-------------------------------------

Comment (by dinhtungdu):

 Replying to [comment:75 azaozz]:
 > @dinhtungdu sorry for the late patch but could you please have a look at
 this asap so it can be added tomorrow :)

 @azaozz  It's 9 am here so it's no problem :D. The patch works great for
 me. I have some questions about the code:

 - Why do we need to check for `window.Element` exist or not?
 - The comment for `hasClass` function is not updated.
 - The indentation of some functions is too deep for me, should we try to
 fix them with early return style (I can patch). IMO, the small indentation
 level increases readability.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47069#comment:76>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list