[wp-trac] [WordPress Trac] #47692: Optgroup in Customizer Select Control

WordPress Trac noreply at wordpress.org
Mon Dec 2 22:58:39 UTC 2019


#47692: Optgroup in Customizer Select Control
-------------------------+-----------------------------
 Reporter:  chintan1896  |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Future Release
Component:  Customize    |     Version:  3.4
 Severity:  normal       |  Resolution:
 Keywords:  needs-patch  |     Focuses:
-------------------------+-----------------------------
Changes (by dlh):

 * keywords:  needs-testing has-patch => needs-patch


Comment:

 Thanks for the updated patch, @chintan1896.

 The new patch does guard against PHP errors, but it still seems to me to
 leave room for developer confusion. If `$optgroup` is changed without
 changing the shape of `$choices`, or vice versa, the control disappears.

 Also, what if the developer wants some choices in an `optgroup` and some
 at the top level of the `select`?

 I also don't see any change to the JavaScript control template in
 [attachment:"47692-new.diff"]. Was it left out by accident?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47692#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list