[wp-trac] [WordPress Trac] #44836: Uploaded plugin installation page: There is an extra <p> tag messing with a link

WordPress Trac noreply at wordpress.org
Thu Apr 4 14:41:00 UTC 2019


#44836: Uploaded plugin installation page: There is an extra <p> tag messing with a
link
---------------------------------------------+-----------------------------
 Reporter:  seedsca                          |       Owner:  SergeyBiryukov
     Type:  defect (bug)                     |      Status:  reviewing
 Priority:  normal                           |   Milestone:  5.2
Component:  Upload                           |     Version:  4.9.8
 Severity:  minor                            |  Resolution:
 Keywords:  good-first-bug has-patch commit  |     Focuses:  ui,
                                             |  administration
---------------------------------------------+-----------------------------

Comment (by ianbelanger):

 Hi @mukesh27,

 Changing `vertical-align: top;` to `vertical-align: baseline;` for these
 selectors:
 {{{
 .wp-core-ui .button-primary.active,
 .wp-core-ui .button-primary.active:hover,
 .wp-core-ui .button-primary.active:focus,
 .wp-core-ui .button-primary:active
 }}}
 Would achieve the same result as simply removing `vertical-align: top;`
 from `.wp-core-ui p .button`, but I think that it is an unnecessary
 change, since there doesn't seem to be anywhere else in core that has this
 bug. I vote for leaving the patch as is.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44836#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list