[wp-trac] [WordPress Trac] #44416: `compact()` will throw notice for undefined variables in PHP 7.3

[WordPress Trac]

#44416: `compact()` will throw notice for undefined variables in PHP 7.3
-------------------------------------------+-----------------------------
 Reporter:  desrosj                        |       Owner:  SergeyBiryukov
     Type:  defect (bug)                   |      Status:  closed
 Priority:  normal                         |   Milestone:  5.0
Component:  General                        |     Version:
 Severity:  normal                         |  Resolution:  fixed
 Keywords:  has-patch needs-testing php73  |     Focuses:
-------------------------------------------+-----------------------------
Changes (by jorbin):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"43819" 43819]:
 {{{
 #!CommitTicketReference repository="" revision="43819"
 php7.3 compatibility: Fix compact throwing notices

 In PHP 7.3, the compact() function has been changed to issue an E_NOTICE
 level error if a passed string refers to an unset variable. In previous
 versions of PHP, this notice was silently skipped. The full RFC can be
 viewed here: https://wiki.php.net/rfc/compact

 This fixes all unit tested code that uses compact.

 Props desrosj.
 Fixes #44416.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44416#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform