[wp-trac] [WordPress Trac] #43986: Disable "Install Plugin" button for PHP required version mismatch

WordPress Trac noreply at wordpress.org
Thu May 31 22:12:33 UTC 2018


#43986: Disable "Install Plugin" button for PHP required version mismatch
-------------------------------------------------+-------------------------
 Reporter:  schlessera                           |       Owner:  (none)
     Type:  task (blessed)                       |      Status:  new
 Priority:  normal                               |   Milestone:  5.0
Component:  Plugins                              |     Version:
 Severity:  major                                |  Resolution:
 Keywords:  needs-unit-tests servehappy dev-     |     Focuses:
  feedback has-patch                             |
-------------------------------------------------+-------------------------

Comment (by afragen):

 Replying to [comment:46 lakenh]:
 > Just a few little accessibility nitpicks with the most recent patch :)
 >
 > As discussed a bit in Slack, the "Why?" link isn't very descriptive on
 its own. There was an aria-label that's also on the "More Details" link
 added, however, that causes a bit of an accessibility problem on its own.
 The link text is now redundant, and that aria-label doesn't describe the
 error, nor tell a screen-reader user that clicking on that will help them
 fix the problem.
 >
 > I still think that the link text should be changed to something that
 tells the entire function of the page it's linking.
 >
 > Alternatively, the WordPress admin has a screen-reader text class, and
 so we could also have the link text be something like `Why <span class
 ="screen-reader-text">is there an installation incompatibility</span>?`.
 >
 > If the aria-label though is the way we're doing it, I'd recommend
 changing it to something like "View plugin installation incompatibility."

 I’ve updated the aria-label in both of the latest patches based upon
 design input.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43986#comment:49>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list