[wp-trac] [WordPress Trac] #43970: Add request type to the confirmation confirmation page - GDPR

[WordPress Trac]

#43970: Add request type to the confirmation confirmation page - GDPR
------------------------------------------+-----------------------------
 Reporter:  garrett-eclipse               |       Owner:  desrosj
     Type:  defect (bug)                  |      Status:  assigned
 Priority:  normal                        |   Milestone:  4.9.6
Component:  General                       |     Version:  trunk
 Severity:  normal                        |  Resolution:
 Keywords:  gdpr has-patch needs-testing  |     Focuses:  administration
------------------------------------------+-----------------------------
Changes (by desrosj):

 * keywords:  gdpr has-patch needs-refresh => gdpr has-patch needs-testing


Comment:

 [attachment:43970.2.diff] has a small handful of improvements.

 - Updates the confirmation notices to match the suggestions on #44029
 - Move the `user_request_action_confirmed_message` filter into the
 `_wp_privacy_account_request_confirmed_message()` function. The function
 was filtering the exact same text in the `wp-login.php` file, so was
 somewhat superfluous. The filter should still exist, though.
 - Added an inline docblock for the `user_request_action_confirmed_message`
 filter.
 - Added missing parameter documentation in the
 `_wp_privacy_account_request_confirmed_message()` function.

 @melchoyce I used the same green color that the admin uses for success
 messages. It seemed a big darker than in your mockup from #44029, though.
 Please check that you are ok with this color, or just send me a different
 hex value.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43970#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform