[wp-trac] [WordPress Trac] #43967: Admin emails after email confirmation don't work for GDPR requests

WordPress Trac noreply at wordpress.org
Wed May 9 23:54:02 UTC 2018


#43967: Admin emails after email confirmation don't work for GDPR requests
---------------------------------------------+-----------------------------
 Reporter:  garrett-eclipse                  |       Owner:  (none)
     Type:  defect (bug)                     |      Status:  new
 Priority:  high                             |   Milestone:  4.9.6
Component:  General                          |     Version:  trunk
 Severity:  normal                           |  Resolution:
 Keywords:  gdpr needs-unit-tests has-patch  |     Focuses:  ui,
                                             |  administration
---------------------------------------------+-----------------------------
Changes (by iandunn):

 * keywords:  gdpr needs-patch => gdpr needs-unit-tests has-patch


Comment:

 It seems like a good goal might be email notifications for 4.9.6, then add
 the wp-admin notifications in a future release? I feel a bit leery about
 adding too much stuff this late in the process.

 [attachment:43967.2.diff] makes these changes:

 * Modularizes the email functionality into a separate function. A side-
 effect of this is that it can now be triggered multiple times, which isn't
 great, but I can't think of any serious problem that creates. It seems
 like the benefits of smaller, more maintainable and testable functions
 outweigh the drawbacks. Having it as a separate callback might also be
 useful for unhooking while batch-processing Multisite requests in the
 future.
 * Use the individual site name/URL, rather than the network name, since
 the export will only contain data related to a single site.
 * Send the email to the network admin, since single site admins won't have
 the capabilities to process the request by default. I added a filter in
 case devs want to send the notifications to a DPO, single site admins,
 etc.
 * Removed the "this email was sent to..." string, see #44030.

 I'd like to get another set of eyes on all this, and some other testers,
 before considering it ready for commit.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43967#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list