[wp-trac] [WordPress Trac] #43644: Revert multiline calls to actions and filters
WordPress Trac
noreply at wordpress.org
Wed Mar 28 10:11:38 UTC 2018
#43644: Revert multiline calls to actions and filters
-------------------------------------+-------------------------------------
Reporter: johnbillion | Owner: johnbillion
Type: task (blessed) | Status: accepted
Priority: normal | Milestone: 5.0
Component: General | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch 2nd-opinion | Focuses: docs, coding-standards
-------------------------------------+-------------------------------------
Comment (by netweb):
Replying to [comment:10 ocean90]:
> I don't think we need a RFC process for this or at all. That's not
really straightforward and just delays stuff unnecessarily. WordPress has
worked pretty well without them. If you need them for WPCS sniffs that's
fine, of course.
> What we need here is 1-2 sentences with a small example for the
Indentation section on our handbook:
>
> > For multi-line argument lists, each argument should start on a new
line and indented once. There should be only one argument per line.
Agreed, if the handbook needs updating update it, the RFC process has
'''not''' been implemented to add bureaucracy for the sake adding
bureaucracy, its for major changes as @azaozz just wrote
[https://github.com/WordPress-Coding-
Standards/rfcs/issues/9#issuecomment-376814321 on GitHub]:
> Also, the RFC process is good when proposing major new changes but IMHO
shouldn't apply when fixing bugs :)
I've added a few more thoughts on this RFC thing being implemented on
GitHub:
> https://github.com/WordPress-Coding-
Standards/rfcs/issues/9#issuecomment-376827944
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43644#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list