[wp-trac] [WordPress Trac] #42985: No error message returned by empty wp-login.php form

[WordPress Trac]

#42985: No error message returned by empty wp-login.php form
---------------------------------------+--------------------------------
 Reporter:  zergling81                 |       Owner:
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  Awaiting Review
Component:  Login and Registration     |     Version:  2.5
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  ui, accessibility
---------------------------------------+--------------------------------
Changes (by birgire):

 * keywords:  needs-patch has-screenshots => has-screenshots has-patch


Comment:

 If {{{wp_signon()}}} is allowed to return the empty username and password
 error, then it could be handled instead in {{{wp-login.php}}}, to avoid
 adding extra {{{$_POST}}} check into the {{{wp_signon()}}} function.

 This is the approach in [attachment:42985.diff].

 Another way would be to only modify {{{wp-login.php}}} and compensate for
 the removal of the {{{empty_username && empty_password}}} errors within
 {{{wp_signon()}}}. But then in that case, we can ask what would be the
 purpose of the current {{{empty_username && empty_password}}} errors
 removal within {{{wp_signon()}}} ;-)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42985#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform