[wp-trac] [WordPress Trac] #43101: Test to ensure MediaElement SWFs aren't accidentally added to build

[WordPress Trac]

#43101: Test to ensure MediaElement SWFs aren't accidentally added to build
--------------------------------+--------------------
 Reporter:  iandunn             |       Owner:
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  5.0
Component:  External Libraries  |     Version:  4.9.2
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:
--------------------------------+--------------------

Comment (by iandunn):

 Replying to [comment:3 ocean90]:
 > Isn't this already covered by `Tests_Admin_IncludesUpdateCore::
 test_new_files_are_not_in_old_files_array_compiled()`?

 That's a good point, I hadn't thought of that. It would catch the case of
 re-adding the currently known SWF files, but it wouldn't catch the case of
 MEjs adding new SWF files, like `mediaelement-flash-video-foo.swf`. It
 also makes it explicitly clear that there are security implications of
 restoring them, which isn't indicated in r42462.

 I'm leaning towards it still being a good idea to add it. What do you
 think, @ocean90 ?
 [[br]]


 > @group 42720 should be @ticket 42720.
 > @since 4.9.2 should be updated to 5.0.0.

 Good catches, thanks Sergey. Fixed in [attachment:43101.2.diff] . That
 also updates it to look at the `build` folder, like
 `test_new_files_are_not_in_old_files_array_compiled()` does.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43101#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform