[wp-trac] [WordPress Trac] #43757: `WP_REST_Attachments_Controller` includes entire admin includes for a few utility functions

WordPress Trac noreply at wordpress.org
Wed Aug 29 03:22:17 UTC 2018


#43757: `WP_REST_Attachments_Controller` includes entire admin includes for a few
utility functions
-------------------------------------+-----------------------------
 Reporter:  lonelyvegan              |       Owner:  SergeyBiryukov
     Type:  enhancement              |      Status:  closed
 Priority:  normal                   |   Milestone:  5.0
Component:  REST API                 |     Version:  trunk
 Severity:  minor                    |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------------
Changes (by rachelbaker):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"43589" 43589]:
 {{{
 #!CommitTicketReference repository="" revision="43589"
 REST API: Limit the scope of wp-admin files required in
 WP_REST_Attachments_Controller methods.

 Narrow the scope of the included wp-admin files loaded for
 `wp_generate_attachment_metadata()`, `wp_handle_upload()`, `wp_tempnam()`,
 and `wp_handle_sideload()`. Requires only wp-admin/includes/file.php and
 wp-admin/includes/image.php instead of wp-admin/includes/admin.php.

 Props lonelyvegan, soulseekah, pratikthink.
 Fixes #43757.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43757#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list