[wp-trac] [WordPress Trac] #42184: Customizer theme install getting stuck on downloading

[WordPress Trac]

#42184: Customizer theme install getting stuck on downloading
--------------------------+-------------------------------
 Reporter:  helen         |       Owner:  celloexpressions
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  4.9
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-------------------------------
Changes (by celloexpressions):

 * keywords:  needs-patch => has-patch


Comment:

 [attachment:42184.1.diff] should take care of most of the issues here, by
 correctly resetting labels and closing the downloading notification when
 the credentials modal is cancelled.

 There are a couple of additional issues that I could not track down. The
 button you pressed breaks if you cancel out of the modal, but all of the
 other buttons still work. The labels can also be incorrectly assigned when
 the theme details modal is open (but not in the grid view). The `aria-
 label` is not reset properly, which may be because any `aria-label`s are
 handled differently in the admin context.

 The best solution is probably to rethink the integration with `updates.js`
 entirely, not changing buttons or showing visible loading indicators from
 there in the customizer because the full-page notification is shown. Much
 of what was added in updates.js undoes what happens there for wp-admin.
 It's a bit late to do that for 4.9, but something to consider for the
 future. For now, [attachment:42184.1.diff] makes most of this functional,
 and if anyone else can dig into the lingering issues further, that would
 be helpful.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42184#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform