[wp-trac] [WordPress Trac] #21622: Validate or sandbox theme file edits before saving them (as is done for plugins)

[WordPress Trac]

#21622: Validate or sandbox theme file edits before saving them (as is done for
plugins)
-------------------------------------+-----------------------------
 Reporter:  eschwartz93              |       Owner:  westonruter
     Type:  enhancement              |      Status:  accepted
 Priority:  high                     |   Milestone:  4.9
Component:  Themes                   |     Version:  2.7.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  administration
-------------------------------------+-----------------------------

Comment (by westonruter):

 Replying to [comment:27 johnbillion]:
 > Also the editors need to be tested with JS disabled just to ensure the
 existing functionality continues to work as expected if there's a JS
 error.

 Replying to [comment:35 jdgrimes]:
 > Looking over the changes, I don't see any issues. I haven't tested it
 though.
 >
 > I do think that @johnbillion raises a good point about it being possible
 to break the editor via JS changes.

 Fallback support for editing when JS is disabled or broken has been
 implemented here: https://github.com/xwp/wordpress-
 develop/pull/272/files/cdc6ddc..5265a9d

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21622#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform