[wp-trac] [WordPress Trac] #42401: Typechecker problem in wp-db.php

[WordPress Trac]

#42401: Typechecker problem in wp-db.php
-------------------------------------------+---------------------
 Reporter:  mkomar                         |       Owner:  pento
     Type:  defect (bug)                   |      Status:  closed
 Priority:  normal                         |   Milestone:  4.9
Component:  Database                       |     Version:  4.8.3
 Severity:  normal                         |  Resolution:  fixed
 Keywords:  has-patch dev-reviewed commit  |     Focuses:
-------------------------------------------+---------------------
Changes (by pento):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"42119"]:
 {{{
 #!CommitTicketReference repository="" revision="42119"
 WPDB: Fix a PHP notice when `AUTH_SALT` is undefined.

 In `wpdb::placeholder_escape()`, the key for `hash_hmac()` falls back to
 `rand()` when `AUTH_SALT` is undefined. `hash_hmac()` requires the key to
 be a string, however, so we need to cast it as such.

 Props mkomar.
 Fixes #42401.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42401#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform