[wp-trac] [WordPress Trac] #39691: wpLink autocomplete search improvement

[WordPress Trac]

#39691: wpLink autocomplete search improvement
-------------------------------+------------------------------
 Reporter:  enrico.sorcinelli  |       Owner:  adamsilverstein
     Type:  enhancement        |      Status:  assigned
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Editor             |     Version:  4.8
 Severity:  normal             |  Resolution:
 Keywords:                     |     Focuses:
-------------------------------+------------------------------

Comment (by adamsilverstein):

 @enrico.sorcinelli Thanks - your patch and tests look good. I'm still not
 sure I understand the dbCollate part: this line:

 `/_ci$/.test( 'undefined' !== typeof dbCollate ? dbCollate : '' )`

 So when dbcollate is devined and ends in `_ci` that means the database is
 case insensitive, so might was well pass lower case only to the query? how
 does that help? it seems like a caching mechanism could do this on the
 server side (lowercase the key based on dbcollate), and you are going to
 quite a bit of effort to make that happen here.

 I would leave that part out unless there is some clear advantage, in which
 case I would explain that wuth an inline doc and ideally we would add
 tests demonstrating the advantage or at least how the dbColate calue
 affects normalizeQuery.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39691#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform