[wp-trac] [WordPress Trac] #41057: Update PHP codebase per WordPress PHP Coding Standards

[WordPress Trac]

#41057: Update PHP codebase per WordPress PHP Coding Standards
----------------------------+-----------------------
 Reporter:  netweb          |       Owner:  pento
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  4.9
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+-----------------------

Comment (by pento):

 Status update time!

 [attachment:phpcs.xml.2.dist] is the current config I'm working with. I
 would not recommend running it at the moment, there are ~160 files still
 failing that I haven't classified and excluded - it seems they mostly fall
 under [https://github.com/WordPress-Coding-Standards/WordPress-Coding-
 Standards/issues/986 WPCS#986], the related [https://github.com/WordPress-
 Coding-Standards/WordPress-Coding-Standards/issues/998 WPCS#998], or
 [https://github.com/WordPress-Coding-Standards/WordPress-Coding-
 Standards/issues/1000 WPCS#1000]. Not being excluded means that `phpcbf`
 takes well over 30 minutes to run on my computer, instead of the usual ~13
 minutes, hence the recommendation not to run it at the moment.

 The good news is, there are very few new issues showing up in my testing,
 they all seem to be related to known issues. The known issues are under
 investigation, or have fix in progress. Many props to the WPCS crew, and
 @jrf in particular, for driving these. :-)

 Finally, for a mildly entertaining testing note,
 `Tests_Pluggable::getDefinedPluggableFunctions()` and
 `Tests_User_Capabilities::testMetaCapsTestsAreCorrect()` will need to
 updated in the final commit - they both assume code formatting that will
 change.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41057#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform