[wp-trac] [WordPress Trac] #40951: New Text Widget - Switching Between Visual/Text Editor Strips Out Code

[WordPress Trac]

#40951: New Text Widget - Switching Between Visual/Text Editor Strips Out Code
-------------------------------------------------+-------------------------
 Reporter:  dwrippe                              |       Owner:
     Type:  defect (bug)                         |  westonruter
 Priority:  normal                               |      Status:  accepted
Component:  Widgets                              |   Milestone:  4.8.1
 Severity:  major                                |     Version:  4.8
 Keywords:  needs-testing has-unit-tests has-    |  Resolution:
  patch                                          |     Focuses:
-------------------------------------------------+-------------------------
Changes (by westonruter):

 * keywords:  needs-patch needs-testing has-unit-tests => needs-testing has-
     unit-tests has-patch


Comment:

 Replying to [comment:87 gitlost]:
 > In the old admin > Appearance > Widgets interface, "wp-
 admin/js/common.js:391" is moving the notice to the top of the screen.

 Thanks for reporting that. I noticed it too. Fixed in
 https://github.com/xwp/wordpress-develop/pull/235/commits/1815910

 All: Pointer functionality can be tested in [attachment:40951.2.diff].

 Note that after you dismiss the admin pointer, you can clear it out to
 test again via WP-CLI: `wp user meta set $WP_USER_ID dismissed_wp_pointers
 ''`

 Should the pointer show more than one time ever for a user? Should it
 instead show once per browser session? (Using `sessionStorage`.)

 I'm not very happy with how it is hacking the z-index to get the pointer
 to appear in the Customizer at the right elevation.

 Again, code is available for review in a GitHub PR: https://github.com/xwp
 /wordpress-develop/pull/235/files

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40951#comment:89>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform