[wp-trac] [WordPress Trac] #28399: Allow WP_Query to query by comment_count column of CPT/posts table

[WordPress Trac]

#28399: Allow WP_Query to query by comment_count column of CPT/posts table
--------------------------------------+------------------
 Reporter:  ramon fincken             |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  4.9
Component:  Query                     |     Version:  4.0
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------
Changes (by boonebgorges):

 * milestone:  Future Release => 4.9


Comment:

 Thank you for circling back to this ticket, @ramon fincken. The patch, and
 especially the tests, are very good.

 I've made some modifications in [attachment:28399.diff]:

 * Added documentation and changed some formatting to match coding
 standards.
 * In the tests, I've used a few convenience methods to simplify your code
 (you'd implemented your own versions of WP's `wp_list_pluck()` and
 `assertEqualSets()`)
 * Rearranged the way the SQL is assembled to be a bit more readable.

 Please review the changes and make sure I've captured everything.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28399#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform