[wp-trac] [WordPress Trac] #41057: Update PHP codebase per WordPress PHP Coding Standards
WordPress Trac
noreply at wordpress.org
Fri Jul 21 02:18:17 UTC 2017
#41057: Update PHP codebase per WordPress PHP Coding Standards
----------------------------+-----------------------
Reporter: netweb | Owner: pento
Type: task (blessed) | Status: accepted
Priority: normal | Milestone: 4.9
Component: General | Version:
Severity: normal | Resolution:
Keywords: | Focuses:
----------------------------+-----------------------
Comment (by jrf):
> With the release of WPCS 0.12.0 should we switch to using 0.12.0 rather
than develop?
For the purposes of this ticket, I would suggest not to switch as
`develop` will always contain the bleeding edge fixes.
Secondly, the next version of WPCS which is currently being developed will
be compatible with PHPCS 3.x, so staying on `develop` will be the quickest
way to also get access to upstream fixes which haven't made it into PHPCS
2.x.
There are still a couple of issues open regarding bugs found in the fixers
- all to do with upstream bugs in PHPCS itself.
I've added a label to all the issues & PRs which relate to this ticket, to
make it easier to get an [https://github.com/WordPress-Coding-Standards
/WordPress-Coding-Standards/issues?utf8=%E2%9C%93&q=label%3A%22Project%3A
%20auto-fix%20WP%20Core%20%2F%20trac-41057%22 overview of the current
status].
Further reviews of the auto-fixes made & bug reports and such would be
very helpful to move this ticket along, so anyone who has some time to
review, please do!
On another note - one of the (merged) PRs covers something which is not
covered by the Handbook, but would solve an issue I saw while reviewing
some auto-fixes in core, so @pento / @netweb may want to add it to the
custom ruleset being used: `WordPress.CodeAnalysis.EmptyStatement`. See
[https://github.com/WordPress-Coding-Standards/WordPress-Coding-
Standards/pull/980 PR 980] for more info.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41057#comment:52>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list