[wp-trac] [WordPress Trac] #25344: Introduce *_network_meta() functions

[WordPress Trac]

#25344: Introduce *_network_meta() functions
-------------------------------------------------+-------------------------
 Reporter:  jeremyfelt                           |       Owner:
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  Future
Component:  Networks and Sites                   |  Release
 Severity:  normal                               |     Version:  3.0
 Keywords:  reporter-feedback has-patch needs-   |  Resolution:
  testing needs-unit-tests                       |     Focuses:  multisite
-------------------------------------------------+-------------------------
Changes (by flixos90):

 * keywords:  reporter-feedback has-patch needs-testing => reporter-feedback
     has-patch needs-testing needs-unit-tests


Comment:

 Some observations on [attachment:25344.8.patch]:

 * Indentation of argument documentation and defaults array in
 `WP_Network_Query` needs to be adjusted.
 * I think we should leave out the adjustments in `wp-includes/meta.php`
 since they are part of #38203.
 * Should the `*_network_meta()` functions live in `wp-includes/ms-
 functions.php` or `wp-includes/ms-blogs.php`?
 * Indentation issues in `get_network_option()` implementation.
 * In `add_network_option()` the function `add_network_meta()` should be
 called with the `$unique` parameter set to true.
 * Was `class-wp-list-table.php` moved in `wp-settings.php` accidentally?
 It should remain before `functions.php`.

 Further thoughts:
 * I think we should split the patch into two parts, one with the actual
 API and the other with the implementation within the network option API.
 * At some point we'll need unit tests as well. Those can pretty much be
 copy/paste (with a few name adjustments obviously) from
 https://core.trac.wordpress.org/attachment/ticket/37923/37923.diff.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25344#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform