[wp-trac] [WordPress Trac] #36862: Inccorrect @since tags in WP_Plugins_List_Table::single_row()

WordPress Trac noreply at wordpress.org
Thu Sep 22 16:20:58 UTC 2016


#36862: Inccorrect @since tags in WP_Plugins_List_Table::single_row()
--------------------------+-------------------
 Reporter:  tfrommen      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.7
Component:  Plugins       |     Version:  4.4
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  docs
--------------------------+-------------------
Changes (by SergeyBiryukov):

 * milestone:  Awaiting Review => 4.7


Comment:

 Some history:
 * `plugin_action_links` was introduced in [7517] (2.5.0).
 * The `$context` parameter was added [8049] (2.6.0).
 * `plugin_action_links_$plugin_file` was added in [9124] (2.7.0).
 * `network_admin_*` versions were added in [17004] (3.1.0).
 * Current docs were added in [34786].

 Replying to [ticket:36862 tfrommen]:
 > In case of the `network_admin_*` filters, also the version is incorrect
 (see the according/general `plugin_*` filters).

 I think the version is correct, as those were introduced in [17004].

 I'm not sure the "As hook_name" notation is needed here. We use that for
 renamed hooks, but these ones were not renamed, just explicitly written
 out. Using it for the last two hooks is also incorrect, because they were
 introduced without `$prefix`.

 [attachment:36862.2.patch] is my take on the corrections.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36862#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list