#17817: do_action/apply_filters/etc. recursion on same filter kills underlying call
----------------------------------------------------+---------------------
Reporter: kernfel | Owner: pento
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 4.7
Component: Plugins | Version: 2.2
Severity: normal | Resolution: fixed
Keywords: has-patch needs-testing has-unit-tests | Focuses:
----------------------------------------------------+---------------------
Comment (by noplanman):
> Incorrect behavior is incorrect behavior and should be fixed.
Absolutely, though utopian. Especially in a large project, it's extremely
difficult to "force" developers/users to use it properly. Because what
does "properly" even mean. This is where flexibility comes in and allowing
developers to express and create amazing things. Of course there are
boundaries, but isn't software here to try to break those?
I totally agree with you, that in the scenario that you described, there
are different way of interpreting what the developer wanted to achieve.
That's a tough boundary to crack, as it's something a machine can't (maybe
yet) know. Edge cases like that are clearly an exception, but should still
have their place, motivating more developers to come up with unique and
gorgeous solutions.
The same will be the case with this fix. Some time down the line, there
will probably be new changes, optimisations, maybe a whole rewrite, who
knows!
But hey, we're all here to learn together, right? Striving to become
better and write smarter code :-)
I think we can put this discussion on pause here, as it isn't really
contributing to this current issue any more, but thanks a lot for
elaborating on your point!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/17817#comment:222>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform