[wp-trac] [WordPress Trac] #24587: Walker_Page and Walker_Nav_Menu not compatible

[WordPress Trac]

#24587: Walker_Page and Walker_Nav_Menu not compatible
------------------------------------------+-----------------------------
 Reporter:  geardev                       |       Owner:  peterwilsoncc
     Type:  defect (bug)                  |      Status:  assigned
 Priority:  normal                        |   Milestone:  Future Release
Component:  Menus                         |     Version:  3.0
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |     Focuses:
------------------------------------------+-----------------------------
Changes (by peterwilsoncc):

 * milestone:  4.7 => Future Release


Comment:

 Bouncing from 4.7.

 I've worked up [attachment:24587.diff] with a helper class and some unit
 tests.

 However, `ArrayAccess` breaks most PHP array functions (including
 `array_merge` used for parsing arguments) so it's way to late to get an
 adequate solution.

 This is a *-early ticket to give consideration to breaking BC and for
 developers to test their code.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/24587#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform