[wp-trac] [WordPress Trac] #38266: Tests: Use assertSame() when the type of the value in the assertion is important

WordPress Trac noreply at wordpress.org
Sun Oct 9 01:57:17 UTC 2016


#38266: Tests: Use assertSame() when the type of the value in the assertion is
important
------------------------------+-----------------------------
 Reporter:  johnbillion       |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Future Release
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  ongoing           |     Focuses:
------------------------------+-----------------------------

Comment (by johnbillion):

 Looks like two of the assertions in `Tests_Cache` are incorrect.

 1. `test_miss()` - `false` is returned from a cache miss, not `null`.
 2. `test_add_get_null()` - a `null` value is retained, not converted to an
 empty string.

 These will need more investigation.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38266#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list