[wp-trac] [WordPress Trac] #38738: Remove front page restrictions from new custom header functions

[WordPress Trac]

#38738: Remove front page restrictions from new custom header functions
--------------------------------------------------+--------------------
 Reporter:  peterwilsoncc                         |       Owner:
     Type:  defect (bug)                          |      Status:  new
 Priority:  normal                                |   Milestone:  4.7
Component:  Themes                                |     Version:  trunk
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch has-unit-tests 2nd-opinion  |     Focuses:
--------------------------------------------------+--------------------

Comment (by flixos90):

 The patch looks good to me. In [attachment:38738.5.diff] I cleared up the
 unit tests a bit:

 * only one assertion per test
 * restoring the `$_wp_theme_features` global happens before the assertion
 so that a failing assertion doesn't pollute further tests

 I agree this is good to go in.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38738#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform