[wp-trac] [WordPress Trac] #36337: Shift-Click to Edit on Custom Logo selects "Remove" button.

[WordPress Trac]

#36337: Shift-Click to Edit on Custom Logo selects "Remove" button.
------------------------------+--------------------------------
 Reporter:  mikeschroder      |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.5
Component:  Customize         |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  ui, accessibility
------------------------------+--------------------------------
Changes (by westonruter):

 * keywords:  has-patch => has-patch commit


Comment:

 @afercia good point, but I think that accessibility improvement is beyond
 the scope of this ticket, as there is no current arg among `$button_logos`
 to provide a more verbose {{aria-label}} like “Remove Button”. Currently
 it is:

 {{{
 'button_labels' => array(
         'select'       => __( 'Select logo' ),
         'change'       => __( 'Change logo' ),
         'remove'       => __( 'Remove' ),
         'default'      => __( 'Default' ),
         'placeholder'  => __( 'No logo selected' ),
         'frame_title'  => __( 'Select logo' ),
         'frame_button' => __( 'Choose logo' ),
 ),
 }}}

 I think we need a second core dev to give a +1 to commit
 [attachment:36337.3.diff]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36337#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform