[wp-trac] [WordPress Trac] #30468: wplink modal accessibility

[WordPress Trac]

#30468: wplink modal accessibility
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  azaozz
     Type:  defect (bug)             |      Status:  closed
 Priority:  high                     |   Milestone:  Future Release
Component:  Editor                   |     Version:  4.0
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots                        |  javascript
-------------------------------------+-------------------------------------
Changes (by azaozz):

 * owner:   => azaozz
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"36991"]:
 {{{
 #!CommitTicketReference repository="" revision="36991"
 wpLink: fix accessibility issues:
 - Add role=dialog and an aria-labelledby attribute to the modal container.
 - Change the modal title to h1.
 - Remove one ` ` that gets read out as `blank` by screen readers.
 - Replace the Cancel link with a button.
 - Clean up unused CSS.

 Props afercia.
 Fixes #30468.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30468#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform