[wp-trac] [WordPress Trac] #35667: Maximum execution time error in WP_Text_Diff_Renderer_Table

[WordPress Trac]

#35667: Maximum execution time error in WP_Text_Diff_Renderer_Table
-------------------------------------+-----------------------
 Reporter:  ocean90                  |       Owner:  ocean90
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.5
Component:  Revisions                |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------
Changes (by codex-m):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 I agree @ocean90 , I debugged this one and it seems there is an issue with
 our existing compute_string_distance() function. These string distances
 seems to be basis for the rest of the matching processes and interleaving
 rows with blanks.In some instances (loop array too large, it seems to
 jumps off its values at some point in the loop). This is because of
 inaccurate string distances.

 I replaced it with a native PHP levenshtein() function and it now works. I
 did some testing for different text revision comparison and seems to work.
 Please confirm. Thanks :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35667#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform