[wp-trac] [WordPress Trac] #33053: download_url() includes query string in temporary filenames

[WordPress Trac]

#33053: download_url() includes query string in temporary filenames
-----------------------------+------------------------------
 Reporter:  Hyperopic        |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  4.2.1
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+------------------------------

Comment (by liegeandlief):

 I have experienced a similar issue when trying to update the Beaver
 Builder plugin on a Windows installation of WordPress 4.4.2. The URL (with
 my key replaced) from which the ZIP file is downloaded is:

 http://updates.wpbeaverbuilder.com/?fl-api-
 method=download_update&license=****************************************&domain=http%3A%2F%2Fwww.novamedia1999.co.uk%2Fwordpress&product=Beaver+Builder+Plugin+%28Standard+Version%29

 This results in the temporary file:

 fl-api-
 methoddownload_updatelicense****************************************domainhttp3A2F2Fwww.novamedia1999
 .co-TZR1bx.tmp

 When _unzip_file_ziparchive tries to unzip the package it fails when it
 tries to create a directory or file with a path name which is too long.

 Obviously this could happen with any theme or plugin depending on the
 length of the directory/file names within the package and the amount of
 nested directories. But I have never had this problem before with any
 other themes or plugins because the length of the temporary file's name
 has never been so long.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33053#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform