[wp-trac] [WordPress Trac] #34278: Add support for embeds in the theme template hierarchy
    WordPress Trac 
    noreply at wordpress.org
       
    Thu Mar  3 22:10:56 UTC 2016
    
    
  
#34278: Add support for embeds in the theme template hierarchy
---------------------------------+------------------------
 Reporter:  johnbillion          |       Owner:
     Type:  task (blessed)       |      Status:  reviewing
 Priority:  normal               |   Milestone:  4.5
Component:  Embeds               |     Version:  4.4
 Severity:  normal               |  Resolution:
 Keywords:  has-patch 4.5-early  |     Focuses:  template
---------------------------------+------------------------
Comment (by swissspidy):
 Replying to [comment:41 DrewAPicture]:
 > @swissspidy We can't just remove the `embed_template` filter, we need to
 support it for back-compat. Otherwise, looks pretty good, other than that
 I'd probably also add a check on `$object` following initialization with
 `get_queried_object()`.
 Regarding the `$object` check, that's not done in any/most of the other
 template functions like `get_category_template()` or
 `get_single_template()`.
 As for the filter, I'm not sure it's worth it / really needed. Let me
 think about it for a bit.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34278#comment:43>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
    
    
More information about the wp-trac
mailing list