[wp-trac] [WordPress Trac] #37024: Safari Quick Edit input[number] text not entirely visible

[WordPress Trac]

#37024: Safari Quick Edit input[number] text not entirely visible
----------------------------+-----------------------------
 Reporter:  joelwills       |      Owner:
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  Awaiting Review
Component:  Administration  |    Version:  trunk
 Severity:  normal          |   Keywords:
  Focuses:                  |
----------------------------+-----------------------------
 '''THE ISSUE'''

 Using an input[number] field in Quick Edit results in the numbers not
 being entirely visible. Safari only (tested in OSX).

 Tested in Chrome and Firefox OSX and is not an issue there.

 [[Image(https://cldup.com/-Z-pYbL0E5.jpg)]]

 ----

 '''STEPS TO REPRODUCE'''

 When in wp-admin under Posts, or Pages, select Quick Edit. Add/change one
 of the fields to be type="number".

 (Or a plugin like WooCommerce will create a number field like this under
 Products when Manage stock is enabled for that product).

 ----

 '''THE CAUSE'''

 The input[number] line-height is set to inherit, and is too large (35px).
 Setting to a smaller number fixes it.

 ----

 '''THE SOLUTION'''

 wp-admin/css/forms.css, line 69.

 Change:

 {{{
 /* Vertically align the number selector with the input. */
 input[type="number"] {
         height: 28px;
         line-height: inherit;
 }
 }}}

 To

 {{{
 /* Vertically align the number selector with the input. */
 input[type="number"] {
         height: 28px;
         line-height: 1;
 }
 }}}

 Tested in Chrome and Firefox and cannot see any affects. Changed forms.css
 attached.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37024>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform