[wp-trac] [WordPress Trac] #32464: Menu args and 'container' => 'false'

[WordPress Trac]

#32464: Menu args and  'container' => 'false'
-----------------------------------+-------------------
 Reporter:  ChiefAlchemist         |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  4.4
Component:  Menus                  |     Version:  4.2
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  docs
-----------------------------------+-------------------
Changes (by DrewAPicture):

 * focuses:   => docs
 * milestone:  Awaiting Review => 4.4


Comment:

 This feels a little bit like developer error, as the argument is not meant
 to be used in a truly boolean fashion. In fact, the passing of `false`
 isn't even a documented feature (in the inline docs).

 I think rather that coding this defensively, we should realistically
 update the inline docs for the `$container` argument to reflect that it
 can accept either a string or `false`.

 Passing anything else could rightly produce unexpected results, as you've
 illustrated.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32464#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform