[wp-trac] [WordPress Trac] #28290: Changing _site_option functions for _network_option functions
WordPress Trac
noreply at wordpress.org
Sat Oct 10 23:30:40 UTC 2015
#28290: Changing _site_option functions for _network_option functions
------------------------------------+-------------------------
Reporter: jmlapam | Owner: jeremyfelt
Type: enhancement | Status: reviewing
Priority: normal | Milestone: 4.4
Component: Options, Meta APIs | Version: 4.0
Severity: normal | Resolution:
Keywords: has-patch dev-feedback | Focuses: multisite
------------------------------------+-------------------------
Comment (by jeremyfelt):
Replying to [comment:46 knutsp]:
> The `$network_id` parameter will default to current network if NULL is
passed, right?
There is a fallback right now to look for the current network. We'll
require the parameter, but if it is false or null, we can look at the
current network.
Replying to [comment:47 spacedmonkey]:
> I think before writing any patch for this, this should have been
decided. Feels like a lot of wasted work for something that ended up being
binned.
Your contributed work is very much appreciated. Iterations will always
continue as part of the process, especially as things become more visible
and more eyes provide feedback.
> So are _site_option() still going to be wrapper functions? You can
easily just pass false / null as network_id and would still work. If this
isn't the case, then we should just crib what JJJ did in WPMN and do a
switch network.
Yes, `_site_option()` would be a wrapper around `_network_option()` for
the current network. While we've talked about network switching a bit,
there's quite a bit involved in fleshing that one out.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/28290#comment:49>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list