[wp-trac] [WordPress Trac] #29257: media_sideload_image() calls rename() on temp file, which can break streams

[WordPress Trac]

#29257: media_sideload_image() calls rename() on temp file, which can break streams
--------------------------+------------------------
 Reporter:  joehoyle      |       Owner:  dd32
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  4.4
Component:  Media         |     Version:  3.9.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------

Comment (by dd32):

 This is pretty interesting, in that PHP internally determines when it
 can't use a standard `rename` (Say, when it's a different disk volume) and
 fakes it using `copy()` instead. Why it doesn't do this with streams I'm
 not sure.. (I can guess..)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29257#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform