[wp-trac] [WordPress Trac] #32482: Fix TinyMCE js include

[WordPress Trac]

#32482: Fix TinyMCE js include
--------------------------+------------------------------
 Reporter:  yoni y        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  TinyMCE       |     Version:  4.2.2
 Severity:  normal        |  Resolution:
 Keywords:  close         |     Focuses:
--------------------------+------------------------------
Changes (by azaozz):

 * keywords:  wp-include, htaccess, security => close
 * type:  task (blessed) => defect (bug)


Comment:

 I'm not that sure what exactly is the purpose here. The TinyMCE JS is
 concatenated and pre-compressed when building, then outputted from a small
 PHP file. It checks some basic support and adds the needed headers. This
 is by far the fastest way to load it. Nothing is being generated on the
 fly, etc.

 > Generating a static file on the file seems like a waste of resources.

 Do you mean concatenating and pre-compressing all the JS parts of TinyMCE
 at build time is a waste?

 > This script mimic a web server changing include headers and decided
 weather to serve a compressed file or a plain text one. this seems like
 something that should be left to the handling web server.

 Unfortunately most shared hosting servers do not add cache expiration,
 content type, etc. headers.

 > Having a php files in the wp-include that runs directly by the web
 server seems like it might have some security implications.

 Not sure what you mean by that. We concatenate and load all admin JS and
 CSS this way.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32482#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform