[wp-trac] [WordPress Trac] #31029: Allow 0 columns in gallery settings

WordPress Trac noreply at wordpress.org
Tue May 12 06:41:38 UTC 2015


#31029: Allow 0 columns in gallery settings
--------------------------------------+-----------------------------
 Reporter:  afercia                   |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Future Release
Component:  Media                     |     Version:  4.1
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  ui, javascript
--------------------------------------+-----------------------------
Changes (by DrewAPicture):

 * keywords:  needs-docs good-first-bug has-patch => good-first-bug has-
               patch


Comment:

 I could advocate for one of three approaches here:

 1. Do nothing

 2. The "decisions not options" route, where we just modify the minimum to
 0 columns, as the ticket description suggests

 If we did this, we'd need to put in logic to ensure 0 would not be the
 default-selected item unless it was in the user settings.

 3. Add a single hook, a filter that allows specifying both the minimum and
 maximum number of columns at the same time. The hook on the option name
 would be skipped as it is out of scope for this ticket.

 The single hook approach is done in [attachment:31029.3.patch]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31029#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list