[wp-trac] [WordPress Trac] #32352: Kill execution at unrecoverable database insert fails

[WordPress Trac]

#32352: Kill execution at unrecoverable database insert fails
--------------------------------------------+------------------------------
 Reporter:  chriscct7                       |       Owner:
     Type:  defect (bug)                    |      Status:  new
 Priority:  high                            |   Milestone:  Awaiting Review
Component:  Database                        |     Version:
 Severity:  major                           |  Resolution:
 Keywords:  dev-feedback needs-patch early  |     Focuses:
--------------------------------------------+------------------------------

Comment (by dd32):

 I'm don't think the proposal here is something we want to / should do.

 In all cases where we insert data to the database, we should be looking at
 the return value to determine if it succeeded, and if not, to take
 appropriate action (ie. `return WP_Error()`, redirect, or `wp_die()`)
 before continuing with any processing.

 In the case of #32308 it was exactly that, the failure to check the return
 values which was ultimately causing a failure.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32352#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform