[wp-trac] [WordPress Trac] #30278: Incorrect background color in auth check modal

[WordPress Trac]

#30278: Incorrect background color in auth check modal
----------------------------+---------------------------------
 Reporter:  melchoyce       |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.2
Component:  Administration  |     Version:  3.6
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  ui, administration
----------------------------+---------------------------------
Changes (by azaozz):

 * keywords:  has-patch dev-feedback => has-patch
 * milestone:  Awaiting Review => 4.2


Comment:

 Replying to [comment:3 valendesigns]:
 > I think it would make more sense to just remove the background color
 completely so when/if the login screen background color changes this
 doesn't happen again.

 That's not going to work. This is the same "problem" all iframe based
 dialogs have: the header containing the Close button is outside of the
 iframe. We could make is a "proper" header (similar to thickbox, etc.) but
 then it will look differently than most others dialogs, see the media
 modal for example.

 Other options include matching the iframe background color, positioning
 the X on top of the iframe or outside the dialog box (seen this in some
 places, not sure it looks that good). Changing the background to `f1f1f1`
 fixes this for now. If you want to experiment with the other options
 please open another ticket with screenshots, etc.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30278#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform