[wp-trac] [WordPress Trac] #5305: permalinks broken when article name is numeric

WordPress Trac noreply at wordpress.org
Thu Feb 12 03:19:54 UTC 2015


#5305: permalinks broken when article name is numeric
-------------------------------------+---------------------------
 Reporter:  thomask                  |       Owner:  valendesigns
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.2
Component:  Permalinks               |     Version:  2.3.1
 Severity:  major                    |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------------
Changes (by valendesigns):

 * keywords:   => has-patch needs-testing


Comment:

 Patch [attachment:5305.5.diff] is ready for testing! I've included 6 new
 unit tests and I feel confident that the issue is now solved. I couldn't
 account for every possible permalink structure, but I feel we now have
 coverage on the majority of them. As well, this fixes posts without
 titles, which has also been a long standing issue.

 I did have to introduce a new filter, as much as I didn't want to, but we
 needed a way to extend this functionality to custom post types without
 having to use the functions I created. Please let me know if there is an
 outlier permalink structure that you know of that wasn't mentioned in the
 comments that needs to be accounted for, or you think I did something in a
 way that doesn't make sense so I can fix it.

 Thanks Guys! And thank you @DrewAPicture for making me the owner.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/5305#comment:60>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list