[wp-trac] [WordPress Trac] #35153: Default link target for media files is none

[WordPress Trac]

#35153: Default link target for media files is none
-----------------------------------+-----------------------
 Reporter:  Clorith                |       Owner:  azaozz
     Type:  defect (bug)           |      Status:  assigned
 Priority:  normal                 |   Milestone:  4.4.1
Component:  Media                  |     Version:  4.4
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  ui
-----------------------------------+-----------------------

Comment (by azaozz):

 Replying to [comment:9 jorbin]:
 > Perhaps there needs to be a second option for other uploads?

 Yeah, it's logical to have different link options for images and other
 uploads. The default workflow is different:
 - Images are better not wrapped in a link, see #31467.
 - All other files should link to the file (the old behaviour), or
 optionally to the attachment page.

 In addition this is affected by letting the user settings override the
 options, see #35101. Even if we change the default in
 `image_default_link_type`, the user can set it to `none` and still trigger
 the above error when inserting attachments that are not images.

 For 4.4.1 we need to ensure the default cannot be `none` for non-image
 attachments. This should still respect the `image_default_link_type`
 option when changed by a plugin.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35153#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform