[wp-trac] [WordPress Trac] #35249: Unit tests should pass

[WordPress Trac]

#35249: Unit tests should pass
------------------------------+------------------------------
 Reporter:  jrf               |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+------------------------------

Comment (by dossy):

 Replying to [comment:20 jrf]:
 > What about this: if the `DB_CHARSET` constant is set to `utf-8`, in the
 WP_INSTALL routine - before adding any tables -, check the DB charset
 with:
 > {{{
 > USE `database_name`
 > SELECT @@character_set_database, @@collation_database
 > }}}
 >
 >
 > If the charset is not `utf8`, run:
 >
 > {{{
 > ALTER DATABASE `database_name` CHARACTER SET `utf8` COLLATE
 `utf8_general_ci`
 > }}}
 >
 >
 > That would prevent the issue altogether without causing issues for
 people who have the DB_CHARSET set to something other than `utf8`.

 I suppose this should be filed as a new ticket, referencing this ticket
 for detailed background rationale, and let the community decide if they
 collectively think it's a good idea?

 I'm not keen on the idea of the installer *changing* the character set and
 collation on an *already existing* database that's being installed into.
 `DB_CHARSET` controlling the charset/collation of a database that's being
 *created* as part of the WP installation, I'm all for.  But, if I
 intentionally created a database OR (regardless of whether it's a bad idea
 or not) want to install WP into a previously existing database, and it
 quietly *changed* the default charset/collation of the database out from
 underneath me?  That would be really bad, and would break assumptions made
 by other users of that database.

 But, if everyone else thinks it's a good idea, I guess that's what really
 matters ... so, put it up to the community with a new ticket?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35249#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform