[wp-trac] [WordPress Trac] #33326: Site Icon: Check return of wp_get_attachment_image_src in get_site_icon_url

[WordPress Trac]

#33326: Site Icon: Check return of wp_get_attachment_image_src in get_site_icon_url
------------------------------+-----------------------
 Reporter:  MikeHansenMe      |       Owner:  obenland
     Type:  defect (bug)      |      Status:  accepted
 Priority:  normal            |   Milestone:  4.3
Component:  Customize         |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------

Comment (by obenland):

 Replying to [comment:6 azaozz]:
 > why do we have `if ( function_exists( 'get_blog_option' ) )` at the top
 of `get_site_icon_url()`? Shouldn't that be `is_multisite()`?

 I was wondering about that too. I think it should.
 [attachment:33326.2.diff] simplifies that a bit, checking for `$blog_id`
 first and switching to `is_multisite()`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33326#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform