[wp-trac] [WordPress Trac] #27583: Move color sanitize function to wp-includes/formatting.php

WordPress Trac noreply at wordpress.org
Sun Mar 30 18:20:32 UTC 2014


#27583: Move color sanitize function to wp-includes/formatting.php
-------------------------------------+------------------------------
 Reporter:  tollmanz                 |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Formatting               |     Version:  3.4
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  template
-------------------------------------+------------------------------

Comment (by tollmanz):

 Replying to [comment:1 downstairsdev]:
 > I attached a patch (27583.diff) that moves the color sanitization
 functions out of 'wp-includes/class-wp-customize-manager.php' and into
 'wp-includes/formatting.php'.  This patch also simplifies the color
 sanitization in  'wp-admin/custom-background.php' and 'wp-admin/custom-
 header.php' by using the "sanitize_hex_color_no_hash" which is now
 available.

 I would argue that this is not appropriate for this ticket. I think
 ''after'' the function are moved into a universally accessible location,
 another ticket should be opened to implement the functions where they
 previously weren't available.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27583#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list