[wp-trac] [WordPress Trac] #16330: media_sideload_image() broken with filenames containing strange characters (e.g., +, %)

[WordPress Trac]

#16330: media_sideload_image() broken with filenames containing strange characters
(e.g., +, %)
-------------------------------------+-----------------------
 Reporter:  Coolkevman               |       Owner:
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.0
Component:  Media                    |     Version:  3.1
 Severity:  major                    |  Resolution:
 Keywords:  needs-unit-tests commit  |     Focuses:
-------------------------------------+-----------------------
Changes (by johnbillion):

 * keywords:  has-patch needs-testing 3.5-early needs-unit-tests => needs-
     unit-tests commit
 * milestone:  Future Release => 4.0


Comment:

 Replacing `+` and `%20` with a dash is the best approach. As mattheu
 mentioned, the backwards compat issue with the `overwrite` flag in
 `wp.uploadFile` is a moot issue because the image will be broken anyway.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16330#comment:39>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform