[wp-trac] [WordPress Trac] #29030: Screen Options Poor Update/Rendering Causes Many things to Break

[WordPress Trac]

#29030: Screen Options Poor Update/Rendering Causes Many things to Break
----------------------------+---------------------------------------------
 Reporter:  codecandid      |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Administration  |     Version:  3.9.1
 Severity:  normal          |  Resolution:
 Keywords:  dev-feedback    |     Focuses:  ui, javascript, administration
----------------------------+---------------------------------------------
Changes (by codecandid):

 * keywords:   => dev-feedback


Comment:

 Checking my hunch, I do believe this is in fact a javascript issue:

 Ajax handler looks for "hidden columns
 here:[https://github.com/WordPress/WordPress/blob/448275cce483138f53ccfa586b2d28b7fe8b0785
 /wp-admin/js/common.js#L29]

 `.manage-column` css selector of each `<th>` uses `:hidden`  to check
 hidden table header's:

 {{{
 hidden : function() {
                 return $('.manage-
 column').filter(':hidden').map(function() { return this.id;
 }).get().join(',');
         },
 }}}

 `manageedit-{$post_type}columnshidden` ajax should not check `:hidden`
 table columns but only checked input fields  in the screen options form to
 better seperate presentation and data handling. This way `cb` and `title`
 should also never get added to `manageedit-{$post_type}columnshidden`.

 I will run some tests to make sure this is in fact it and try to write a
 patch later this weekend. My jquery is average at best, so if anyone else
 can figure this out be my guest!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29030#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform