[wp-trac] [WordPress Trac] #28893: No margin bottom when the post type only has a title
WordPress Trac
noreply at wordpress.org
Thu Jul 17 13:26:48 UTC 2014
#28893: No margin bottom when the post type only has a title
-------------------------------+--------------------
Reporter: markoheijnen | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.0
Component: Posts, Post Types | Version: trunk
Severity: normal | Resolution:
Keywords: | Focuses: ui
-------------------------------+--------------------
Comment (by markoheijnen):
Is this tone of voice really needed? I forgot about the action
{{{edit_form_after_editor}}}. Besides that the patch I provided is totally
fine and fix the issue because {{{wp-admin/css/edit.css}}} is only loaded
on the edit post screen which only uses {{{.edit-form-section}}} once.
I did added a second patch which solves the issue without breaking stuff.
I do have to admin using a negative margin is ugly. Reason I did this was
that otherwise you have to change to many values in the editor but I can
be wrong about that.
That said I still think putting a margin-bottom on {{{.edit-form-
section}}} is wrong to do. If this is a helper class then it should not
have different behaviours depending on the context of the page. You can
use the class on the edit comment page but then you don't get the margin-
bottom. To me that is weird but if that is intended behaviour then that is
fine to me.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/28893#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list