[wp-trac] [WordPress Trac] #26212: Twenty Fourteen: add arrows for image template navigation
WordPress Trac
noreply at wordpress.org
Fri Jul 11 16:33:26 UTC 2014
#26212: Twenty Fourteen: add arrows for image template navigation
------------------------------+------------------
Reporter: celloexpressions | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 4.0
Component: Bundled Theme | Version: 3.8
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
------------------------------+------------------
Changes (by celloexpressions):
* keywords: has-patch ux-feedback => has-patch
Comment:
Looks like [attachment:26212.2.diff] still applies (to src) and works for
me, surprisingly. Should be reasonably backwards compatible - any custom
styling on the slider arrows should also work here (and in most cases
would be desired). Fourteen Colors works seamlessly with this change, for
example.
The biggest issue I can find is that with images that are less than 810px
wide, the arrows end up floating into the image margin, which looks very
broken. [attachment:26212.4.diff] solves this by adding the placeholder
background that's displayed on featured images (without the hover states).
This ensures that the arrows are always in the same place, and few images
will be this small here.
Other thing is the behavior on the first and last images, when there's
only one arrow. Not sure what to do about those, or whether we need to
worry about it.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/26212#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list