[wp-trac] [WordPress Trac] #28739: r28523 __call() some functions expecting params by reference

[WordPress Trac]

#28739: r28523 __call() some functions expecting params by reference
--------------------------+-----------------------------
 Reporter:  sboisvert     |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Query         |    Version:  trunk
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 Given this code:

 {{{
 $wp_query->parse_tax_query($wp_query->query_vars);
 }}}

 you will get:
 Warning: Parameter 1 to WP_Query::parse_tax_query() expected to be a
 reference, value given

 https://github.com/voceconnect/objects-to-objects is an example of where
 this code is used.

 changing parse_tax_query()'s declaration to public fixes this.

 This was introduced in r28523

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28739>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform