[wp-trac] [WordPress Trac] #27365: Upgrader bulk_upgrade() functions do not return the correct data

[WordPress Trac]

#27365: Upgrader bulk_upgrade() functions do not return the correct data
---------------------------------+-----------------------------
 Reporter:  chrisjean            |       Owner:
     Type:  defect (bug)         |      Status:  new
 Priority:  normal               |   Milestone:  Future Release
Component:  Upgrade/Install      |     Version:  2.9
 Severity:  normal               |  Resolution:
 Keywords:  has-patch 4.0-early  |     Focuses:
---------------------------------+-----------------------------

Comment (by jdgrimes):

 Replying to [comment:14 dd32]:
 > FWIW, it looks like the changes here are probably correct, most of the
 $this->result should be replaced with simply $result, except in the Theme
 Upgrader where it is something else.
 >
 > At present for example, Plugin_Upgrader->upgrade() returns null for
 failures instead of the WP_Error.
 >
 > Sorry @chrisbliss18 but as you can probably tell, following some of the
 code isn't as easy as you expect at first glance.

 Indeed the code is difficult to follow, and I don't ''think'' that
 `$this->result` is any different than elsewhere in the theme upgrader's
 `install()` and `upgrade()` methods, though I haven't examined
 `bulk_upgrade()` closely.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27365#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform