[wp-trac] [WordPress Trac] #27982: Stop passing boolean values to mysqli_fetch_object()

[WordPress Trac]

#27982: Stop passing boolean values to mysqli_fetch_object()
-----------------------------------+-----------------------
 Reporter:  markjaquith            |       Owner:  pento
     Type:  defect (bug)           |      Status:  accepted
 Priority:  normal                 |   Milestone:  3.9.1
Component:  Database               |     Version:  3.9
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+-----------------------

Comment (by markjaquith):

 Our query type handling misses "SET" queries. Those hit the else branch.
 Those have a boolean result. We then try to pass that boolean to
 `mysqli_fetch_object()`.

 I think we can safely skip the while loop if `is_bool( $this->result )`.
 Passing a boolean to `mysqli_fetch_object() is bad behavior.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27982#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform